update mbedtls to v3.6.5-idf#103
Conversation
|
@ericschaal Do you plan to finish this? It is still in draft, and there is no description (though it is pretty obvious what you are doing). Let me know if you do, and once ready "un"-draft this so that I can take a look. |
09354b4 to
b97c672
Compare
|
Are we still dealing with the same issue as here: fortanix/rust-mbedtls#320 ? |
Not sure how that's related. Can you elaborate? I think this PR is just addressing #72? |
|
I don't remember if it was you or someone else that said it, but I remember someone saying that one roadblock to upgrading mbedtls would be this "thread-safety" issue. I could be hallucinating tho... |
I never said this I think. If for nothing else, because the current 3.4.x MbedTLS we use is having exactly the same thread-safety issues which rust-mbedtls refers to. I don't understand the thread-safety issues in a good detail ATM, I must admit. But also and for embedded use-cases where you don't have threads they shouldn't matter. That is, unless you use |
421a495 to
f61e782
Compare
|
Hey @ivmarkov, just updated the description and removed the draft status. |
Out of pure curiosity, can you elaborate a bit on the issues you were having? |
|
@ericschaal I think the PR looks good! If only you could:
|
ericschaal
left a comment
There was a problem hiding this comment.
Hey @ivmarkov, I revised my approach for inttypes.h, let me know want you think.
|
Before merging, we will need to test that examples are still fully working, within their performance range or better. Also, we should check if there's a significant change in the final binary size. |
True. @ericschaal Would you mind testing the examples? @AnthonyGrondin I'm very tempted to merge this here. It is "a lot of scripts", but we can hide it in @bjoernQ Hope you don't mind? This is what Here, how it looks typically: project-chip/rs-matter#366 (comment) |
I opened a new issue about that: |
|
For sure, I'll test what I can and report back! But I only have an esp32s3 on hand at the moment unfortunately. |
|
No-std examples Crypto Self Test (baremetal no-std)MCU: esp32s3 Crypto Mini Test (baremetal no-std)MCU: esp32s3 Client (baremetal no-std)MCU: esp32s3 EDIT: re-ran crypto self test with --release |
|
std examples Crypto Self Test (std)MCU: esp32s3 Server (std)MCU: esp32s3 Client (baremetal no-std)MCU: esp32s3 |
|
I think we should also update config.h to the latest version as done in this commit. |
@ericschaal Good idea. Can you pull that update into this PR? |
did my best to keep the same feature set as when using mbedtls 3.4.0
|
@ericschaal You need to rebase on top of the main branch, which got #106 merged in the meantime. |
|
Once the build is ready (including the new libs) I'll test with esp32s3, esp32c3 and esp32c6 and if all is well, we can merge. |
|
Thanks! Tested and works on esp32s3, esp32c3 and esp32c6. |
Upgrade mbedtls to mbedtls-3.6.5-idf
This PR upgrades from 3.4.x to 3.6.5 to resolve TLS 1.3 issues I encountered during testing.
Context
Would appreciate review from maintainers familiar with the project to assess whether this is a safe upgrade path.
Addresses #72